miniblog.

← Back to all posts

Wilfred Hughes

Jun 26, 2018 at 21:28

Turns out that patching Emacs' library loading whilst silencing user feedback can lead to some really interesting bugs: https://github.com/cask/shut-up/pull/12/commits/2495e8bf3d424f88f82679dd94def6b87960c4a9 This might be the longest commit message I've ever written. I think a good message tries to persuade the maintainer to accept the PR.

Don't clobber original definitions if shut-up is loaded twice by Wilfred · Pull Request #12 · cask/shut-up

Don't clobber original definitions if shut-up is loaded twice by Wilfred · Pull Request #12 · cask/shut-up

Previously, shut-up would save the original functions for message and load whenever shut-up.el was loaded. This assumed that shut-up.el was only loaded once, and would only be loaded when message a...